[all-commits] [llvm/llvm-project] 569280: compiler-rt: Stop using APPLE cmake variable

[Matt Arsenault via All-commits]

  Branch: refs/heads/users/arsenm/compiler-rt/use-apple-triple-not-apple-cmake
  Home:   https://github.com/llvm/llvm-project
  Commit: 569280f1af8dd0aff9203cce260145a30da87951
      https://github.com/llvm/llvm-project/commit/569280f1af8dd0aff9203cce260145a30da87951
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2026-06-11 (Thu, 11 Jun 2026)

  Changed paths:
    M compiler-rt/CMakeLists.txt
    M compiler-rt/cmake/Modules/AddCompilerRT.cmake
    M compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake
    M compiler-rt/cmake/Modules/CompilerRTCompile.cmake
    M compiler-rt/cmake/Modules/CompilerRTUtils.cmake
    M compiler-rt/cmake/base-config-ix.cmake
    M compiler-rt/cmake/builtin-config-ix.cmake
    M compiler-rt/cmake/config-ix.cmake
    M compiler-rt/cmake/crt-config-ix.cmake
    M compiler-rt/lib/asan/CMakeLists.txt
    M compiler-rt/lib/asan/tests/CMakeLists.txt
    M compiler-rt/lib/asan_abi/CMakeLists.txt
    M compiler-rt/lib/builtins/CMakeLists.txt
    M compiler-rt/lib/fuzzer/tests/CMakeLists.txt
    M compiler-rt/lib/interception/tests/CMakeLists.txt
    M compiler-rt/lib/lsan/CMakeLists.txt
    M compiler-rt/lib/nsan/CMakeLists.txt
    M compiler-rt/lib/orc/CMakeLists.txt
    M compiler-rt/lib/orc/tests/CMakeLists.txt
    M compiler-rt/lib/profile/CMakeLists.txt
    M compiler-rt/lib/rtsan/CMakeLists.txt
    M compiler-rt/lib/rtsan/tests/CMakeLists.txt
    M compiler-rt/lib/sanitizer_common/CMakeLists.txt
    M compiler-rt/lib/sanitizer_common/tests/CMakeLists.txt
    M compiler-rt/lib/stats/CMakeLists.txt
    M compiler-rt/lib/tsan/dd/CMakeLists.txt
    M compiler-rt/lib/tsan/rtl/CMakeLists.txt
    M compiler-rt/lib/tsan/tests/CMakeLists.txt
    M compiler-rt/lib/tysan/CMakeLists.txt
    M compiler-rt/lib/ubsan/CMakeLists.txt
    M compiler-rt/lib/ubsan_minimal/CMakeLists.txt
    M compiler-rt/lib/xray/CMakeLists.txt
    M compiler-rt/lib/xray/tests/CMakeLists.txt
    M compiler-rt/test/asan/CMakeLists.txt
    M compiler-rt/test/asan_abi/CMakeLists.txt
    M compiler-rt/test/builtins/CMakeLists.txt
    M compiler-rt/test/cfi/CMakeLists.txt
    M compiler-rt/test/dfsan/CMakeLists.txt
    M compiler-rt/test/fuzzer/CMakeLists.txt
    M compiler-rt/test/interception/CMakeLists.txt
    M compiler-rt/test/lsan/CMakeLists.txt
    M compiler-rt/test/msan/CMakeLists.txt
    M compiler-rt/test/profile/CMakeLists.txt
    M compiler-rt/test/rtsan/CMakeLists.txt
    M compiler-rt/test/safestack/CMakeLists.txt
    M compiler-rt/test/sanitizer_common/CMakeLists.txt
    M compiler-rt/test/tsan/CMakeLists.txt
    M compiler-rt/test/tysan/CMakeLists.txt
    M compiler-rt/test/ubsan/CMakeLists.txt
    M compiler-rt/test/ubsan_minimal/CMakeLists.txt

  Log Message:
  -----------
  compiler-rt: Stop using APPLE cmake variable

Use a variable derived from the target triple instead.
This is a partial fix for cross compiling the GPU runtimes
on macos. Previously on mac hosts, the build system would go
down completely wrong paths. This improves the situation by
moving the failures to compilation pulling in host flags which
shouldn't be forwarded.

Despite the cmake documentation claiming the APPLE constant
is "Set to True when the target system is an Apple platform",
this appears to be true when the host is apple. Not sure if this
is worth reporting as a cmake bug, or if it's an artifact of some
runtimes build specifics. Change to using a new variable computed
from the target triple. Presumably the same bug exists for the various
WIN32 and ANDROID checks around, there are just fewer of them.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications