[all-commits] [llvm/llvm-project] 18cec0: [lit] Deprecate execute_external=True in ShTest (#...

[Aiden Grossman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 18cec023e10f4067b0e0bfa48c9a4209de6fd699
      https://github.com/llvm/llvm-project/commit/18cec023e10f4067b0e0bfa48c9a4209de6fd699
  Author: Aiden Grossman <aidengrossman at google.com>
  Date:   2026-06-11 (Thu, 11 Jun 2026)

  Changed paths:
    M llvm/utils/lit/lit/formats/shtest.py
    M llvm/utils/lit/tests/Inputs/per-test-coverage-by-lit-cfg/lit.cfg
    M llvm/utils/lit/tests/Inputs/per-test-coverage/lit.cfg
    M llvm/utils/lit/tests/Inputs/shtest-external-shell-kill/lit.cfg
    M llvm/utils/lit/tests/Inputs/shtest-format/external_shell/lit.local.cfg
    M llvm/utils/lit/tests/Inputs/shtest-readfile/lit.cfg
    M llvm/utils/lit/tests/Inputs/shtest-run-at-line/external-shell/lit.local.cfg
    M llvm/utils/lit/tests/Inputs/shtest-timeout/lit.cfg

  Log Message:
  -----------
  [lit] Deprecate execute_external=True in ShTest (#201732)

Implementing the deprecation part of

https://discourse.llvm.org/t/rfc-removal-of-the-lit-external-shell/90951.

I made this a hard error with an additional keyword argument to opt out
of the warning behavior given we don't have the facilities to trivially
log within ShTest like we do in the rest of lit, and I think forcing
people to explicitly acknowledge that things are deprecated is not a bad
thing.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications