[all-commits] [llvm/llvm-project] 59e18f: [clang] `this` getter missed in ConstructAttribute...

[Jameson Nash via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 59e18f41b35de71799ad8f2f615e3c01bac86e1e
      https://github.com/llvm/llvm-project/commit/59e18f41b35de71799ad8f2f615e3c01bac86e1e
  Author: Jameson Nash <vtjnash at gmail.com>
  Date:   2026-06-11 (Thu, 11 Jun 2026)

  Changed paths:
    M clang/lib/CodeGen/CGCall.cpp

  Log Message:
  -----------
  [clang] `this` getter missed in ConstructAttributeList (#203010)

In https://reviews.llvm.org/D159247 (400d3261a0da56554aee8e5a2fbc27eade9d05db)
it looks intended to update all of these calls, but missed this. The
effect is that a reference `&this` in a non-zero addrspace would take
this branch and crash there (because it ends up asserting that `this`
is a pointer). DRY the code since this branch looks like it kept
getting copied more incorrectly over time. I don't have an actual use
or test for this, I just noticed it while I was trying to break other
things in fuzzing.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications