[all-commits] [llvm/llvm-project] f4a027: [lldb-dap] Support loading core files through atta...

[Alexandre Perez via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f4a027364add48b3522ead105494187ded58047f
      https://github.com/llvm/llvm-project/commit/f4a027364add48b3522ead105494187ded58047f
  Author: Alexandre Perez <alexandreperez at meta.com>
  Date:   2026-06-11 (Thu, 11 Jun 2026)

  Changed paths:
    M lldb/test/API/tools/lldb-dap/coreFile/TestDAP_coreFile.py
    M lldb/tools/lldb-dap/Handler/AttachRequestHandler.cpp

  Log Message:
  -----------
  [lldb-dap] Support loading core files through attachCommands (#202785)

The `attachCommands` attach option lets users bootstrap a session with
arbitrary LLDB commands, but a command that loaded a core (e.g. `target
create --core`) produced a broken session:
`ConfigurationDoneRequestHandler` would call `process.Continue()` on the
core and fail, because the non-live-session handling was keyed on the
`coreFile` attach argument rather than on the actual resulting process.

This teaches `AttachRequestHandler` to detect, after the attach commands
run, whether the selected process was loaded from a core via the
`SBProcess:: IsLiveDebugSession()` API added in #203111. When it is a
core, it sets `stop_at_entry` and clears `is_live_session`, mirroring
what the `coreFile` key does.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications