[all-commits] [llvm/llvm-project] 7571b8: [CIR] NFC: Address byval review feedback in CallCo...

[adams381 via All-commits]

  Branch: refs/heads/users/adams381/cir-callconv-lowering-byval
  Home:   https://github.com/llvm/llvm-project
  Commit: 7571b8b0689cdc8de1c789080053a8b303af8eab
      https://github.com/llvm/llvm-project/commit/7571b8b0689cdc8de1c789080053a8b303af8eab
  Author: Adam Smith <adams at nvidia.com>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M clang/lib/CIR/Dialect/Transforms/TargetLowering/CIRABIRewriteContext.cpp

  Log Message:
  -----------
  [CIR] NFC: Address byval review feedback in CallConvLowering

Second-pass review cleanup on the byval/byref argument lowering in
CIRABIRewriteContext, no functional change.

updateArgAttrs now builds its attributes through an mlir::Builder, so the
arg-attr construction reads as getNamedAttr / getI64IntegerAttr /
getUnitAttr instead of spelling out StringAttr::get and the IntegerType
plumbing by hand; the Extend branch loses its empty-vs-nonempty special
case since the append path handles both.  The llvm.byval / llvm.byref
comment now says why the pointee type is carried explicitly: it is a
typed attribute and the type cannot be recovered from the opaque LLVM
pointer after lowering.

insertArgCoercion gains an early continue for the classifications that
need no entry-block fixup (Extend, Ignore, and Direct without coercion),
so the remaining if/else covers exactly the two cases that do work
(Direct-with-coercion and Indirect) with no silent do-nothing branch.

The call-site type capture uses llvm::append_range over
argOperands.getTypes(), the Direct call-site arm gets braces to match its
else if, and the two stray em-dashes in the byval comment become ASCII.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications