[all-commits] [llvm/llvm-project] 1b4d60: [lldb] Remove ValueObjectRecognizerSynthesizedValu...

[Dave Lee via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1b4d60d7f67130d693c7b11d8fd35f59f6911cae
      https://github.com/llvm/llvm-project/commit/1b4d60d7f67130d693c7b11d8fd35f59f6911cae
  Author: Dave Lee <davelee.com at gmail.com>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M lldb/include/lldb/Target/StackFrameRecognizer.h

  Log Message:
  -----------
  [lldb] Remove ValueObjectRecognizerSynthesizedValue::IsSynthetic override (#199117)

Removes the `IsSynthetic` override on
`ValueObjectRecognizerSynthesizedValue`. This class does not also
override `GetNonSyntheticValue`.

There was a bug in which code assumed that when `IsSynthetic()` returned
true, that `GetNonSyntheticValue` would produce a different value
object. However the default behavior of `GetNonSyntheticValue` is to
return itself.

It seems to me that either:
1. `ValueObjectSynthetic` should be the only class to override
`IsSynthetic` to true
2. or, that classes which override `IsSynthetic` should also override
`GetNonSyntheticValue`

In either case, I think it's best to remove this `IsSynthetic` on
`ValueObjectRecognizerSynthesizedValue`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications