[all-commits] [llvm/llvm-project] f3d5fd: [lldb][Windows] Fix ECHO_TO_FILE/ECHO_APPEND_FILE ...

[Charles Zablit via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f3d5fda2faef6d7098f8dfb2b0278e2a278c83e6
      https://github.com/llvm/llvm-project/commit/f3d5fda2faef6d7098f8dfb2b0278e2a278c83e6
  Author: Charles Zablit <c_zablit at apple.com>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/make/Makefile.rules

  Log Message:
  -----------
  [lldb][Windows] Fix ECHO_TO_FILE/ECHO_APPEND_FILE (#202968)

The Windows recipes for these macros were printf "%s\n" $(1). The
callers wrap content in single quotes (for the POSIX printf), but the
test recipes run under cmd.exe on Windows, which keeps the single quotes
literal and word-splits on spaces, and the bundled printf additionally
mangles backslashes and spaces. The result is garbage generated files
(e.g. a modulemap whose first line is 'module, or a truncated SDK path
from a "Program Files" directory).

Write the file with cmd's echo after stripping the callers' single
quotes. echo runs in the recipe shell, so unlike GNU make's $(file ...)
it still works after a preceding MKDIR_P in the same recipe.

This is a reland of https://github.com/llvm/llvm-project/pull/202612
which add the changes in the wrong if/else branch.

rdar://179218545



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications