[all-commits] [llvm/llvm-project] a6b58e: [mlir][acc] Add ignore-default-none option to ACCI...

[Razvan Lupusoru via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a6b58e00ceddef9c363fa8e19eb2ab530d0d9658
      https://github.com/llvm/llvm-project/commit/a6b58e00ceddef9c363fa8e19eb2ab530d0d9658
  Author: Razvan Lupusoru <razvan.lupusoru at gmail.com>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M mlir/include/mlir/Dialect/OpenACC/Transforms/Passes.td
    M mlir/lib/Dialect/OpenACC/Transforms/ACCImplicitData.cpp
    A mlir/test/Dialect/OpenACC/acc-implicit-data-defaultnone.mlir

  Log Message:
  -----------
  [mlir][acc] Add ignore-default-none option to ACCImplicitData (#202442)

ACCImplicitData currently skips implicit data mapping when a visible
default(none) clause is present, per the OpenACC rule that no implicit
data attributes apply in that case.

That default is reasonable when a frontend already verifies
default(none) and ensures all user variables have an explicit data
clause. Without that checking, generating implicit mappings would risk
silently mapping user variables that should have been explicit under
default(none).

There are still cases where implicit mapping is needed even with
default(none):
- The frontend reports default(none) violations as warnings and
compilation continues, so some user variables may reach this pass
without explicit data clauses and still need implicit mapping.
- Compiler-generated temps or interior pointers may be live-in to the
region and still require implicit mapping even when all user variables
are already explicitly mapped.

In those cases, skipping implicit data entirely is too conservative.

Add an ignore-default-none pass option (default: false) to generate
implicit data mappings even when default(none) is present.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications