[all-commits] [llvm/llvm-project] e5e61f: [lldb][Windows] Surface DebugBreakProcess Halt() a...

[Charles Zablit via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e5e61fc32f6a9dd4fa75d932e9a7177a1b2bec28
      https://github.com/llvm/llvm-project/commit/e5e61fc32f6a9dd4fa75d932e9a7177a1b2bec28
  Author: Charles Zablit <c_zablit at apple.com>
  Date:   2026-06-10 (Wed, 10 Jun 2026)

  Changed paths:
    M lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp
    M lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.h

  Log Message:
  -----------
  [lldb][Windows] Surface DebugBreakProcess Halt() as a SIGSTOP signal stop (#201885)

With #201884, each keystroke arriving while the debuggee is running
triggers a `\x03` BREAK. On Windows, the halt is implemented by
injecting a thread that fires an int3. However, the resulting breakpoint
exception was being reported as a real `__debugbreak()` (SIGTRAP). The
client treats that as a genuine stop, ends the continue, and stdin
forwarding ships at most one byte per BP hit.

With this patch, when a halt is pending, the server treats the next
breakpoint as the halt acknowledgement and report it as SIGSTOP instead
of SIGTRAP. The client then resumes the debuggee automatically, making
the brief halt transparent.

This is a follow up to https://github.com/llvm/llvm-project/pull/201884.

rdar://178725947

---------

Co-authored-by: Nerixyz <nero.9 at hotmail.de>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications