[all-commits] [llvm/llvm-project] 5d3dd5: Resolve feedback about MapInfoFinalization

[Chi-Chun, Chen via All-commits]

  Branch: refs/heads/users/cchen/flang_openmp_motion_map_iterator
  Home:   https://github.com/llvm/llvm-project
  Commit: 5d3dd5981a98ab72ca042e0485a81977dbb26490
      https://github.com/llvm/llvm-project/commit/5d3dd5981a98ab72ca042e0485a81977dbb26490
  Author: Chi Chun, Chen <chichun.chen at hpe.com>
  Date:   2026-06-09 (Tue, 09 Jun 2026)

  Changed paths:
    M flang/lib/Optimizer/OpenMP/MapInfoFinalization.cpp
    M flang/test/Transforms/omp-map-info-finalization.fir

  Log Message:
  -----------
  Resolve feedback about MapInfoFinalization

Keep MapInfoFinalization from expanding `omp.map.info` operations nested
in omp.iterator regions. Those maps are yielded through the iterator
result, so rewriting them as outer target operands can violate SSA
dominance.


  Commit: 89667ede7760c002c6956d67110d74b41b01520a
      https://github.com/llvm/llvm-project/commit/89667ede7760c002c6956d67110d74b41b01520a
  Author: Chi Chun, Chen <chichun.chen at hpe.com>
  Date:   2026-06-09 (Tue, 09 Jun 2026)

  Changed paths:
    M flang/include/flang/Utils/OpenMP.h
    M flang/lib/Lower/OpenMP/ClauseProcessor.cpp
    M flang/lib/Utils/OpenMP.cpp

  Log Message:
  -----------
  Resolve feedback about createMapInfoOp usage

Build iterator-generated map entries through the shared createMapInfoOp
helper while preserving the FIR `var_ptr` type used to derive the OpenMP
`varPtrType` for `!llvm.ptr` iterator results.


  Commit: 8b0885ccb3552706016229e42a8c98abaf3008ba
      https://github.com/llvm/llvm-project/commit/8b0885ccb3552706016229e42a8c98abaf3008ba
  Author: Chi Chun, Chen <chichun.chen at hpe.com>
  Date:   2026-06-09 (Tue, 09 Jun 2026)

  Changed paths:
    M flang/lib/Lower/OpenMP/ClauseProcessor.cpp
    M flang/lib/Lower/OpenMP/OpenMP.cpp
    A flang/test/Lower/OpenMP/Todo/map-iterator-derived-member.f90
    A flang/test/Lower/OpenMP/Todo/motion-iterator-derived-member.f90
    A flang/test/Lower/OpenMP/Todo/target-iterator-derived-member.f90

  Log Message:
  -----------
  Resolve feedback about iterator member maps

Reject iterator-dependent derived type member maps for now. These maps
would otherwise bypass the parent/member bookkeeping in processMapObjects,
including parentMemberIndices construction and mapper resolution with
hasParentObj=true.

Without that bookkeeping, lowering map(iterator(...): x%a(i)) could emit
an incomplete parent partial map. Emit a TODO instead of silently generating
incorrect or incomplete mapping IR.


  Commit: d9b8a322a7fd337c14cc5d1a480f95460bf0cfb5
      https://github.com/llvm/llvm-project/commit/d9b8a322a7fd337c14cc5d1a480f95460bf0cfb5
  Author: Chi Chun, Chen <chichun.chen at hpe.com>
  Date:   2026-06-09 (Tue, 09 Jun 2026)

  Changed paths:
    M flang/lib/Lower/OpenMP/Utils.cpp

  Log Message:
  -----------
  Add comment about iterator map bounds

Clarify why iterator map lowering keeps a stable base address while
lowering iterator-dependent subscripts inside the omp.iterator body.
This documents the difference from ordinary map bounds generation.


  Commit: dc732c735c2931de5ea853b16343294a4db178f4
      https://github.com/llvm/llvm-project/commit/dc732c735c2931de5ea853b16343294a4db178f4
  Author: Chi Chun, Chen <chichun.chen at hpe.com>
  Date:   2026-06-09 (Tue, 09 Jun 2026)

  Changed paths:
    M flang/lib/Lower/OpenMP/ClauseProcessor.cpp
    M flang/lib/Lower/OpenMP/ClauseProcessor.h

  Log Message:
  -----------
  Preserve iterator-dependent locators in shared map lowering

Share the iterated-map handling between map and motion clauses while
preserving iterator-dependent locators on map_iterated and keeping
standard map lowering for other clause objects.


Compare: https://github.com/llvm/llvm-project/compare/a360574fe276...dc732c735c29

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications