[all-commits] [llvm/llvm-project] 65176c: [CodeGen] Fix incorrect rematerialization rollback...

Lucas Ramirez via All-commits all-commits at lists.llvm.org
Tue Jun 9 07:23:01 PDT 2026


  Branch: refs/heads/users/lucas-rami/rematerializer-fix-rollback-order
  Home:   https://github.com/llvm/llvm-project
  Commit: 65176c5f3e35e43ca25f7848df02dfc29251813e
      https://github.com/llvm/llvm-project/commit/65176c5f3e35e43ca25f7848df02dfc29251813e
  Author: Lucas Ramirez <lucas.rami at proton.me>
  Date:   2026-06-09 (Tue, 09 Jun 2026)

  Changed paths:
    M llvm/include/llvm/CodeGen/Rematerializer.h
    M llvm/lib/CodeGen/Rematerializer.cpp
    M llvm/unittests/CodeGen/RematerializerTest.cpp

  Log Message:
  -----------
  [CodeGen] Fix incorrect rematerialization rollback order

This fixes an issue in the rematerializer's rollbacker wherein adjacent
MIs that were deleted through rematerializations would
sometimes---depending on the exact order in which they were
deleted---not be re-created in their original
pre-rematerialization order. While this does not impact correctness
(i.e., use-def relations are always honored), this goes against the
rollbacker's intent to re-create the MIR exactly as it was
pre-rematerializations (up to slot index changes).


  Commit: d6b5e8f716741f00e46b852252e5d46d9f89e5b5
      https://github.com/llvm/llvm-project/commit/d6b5e8f716741f00e46b852252e5d46d9f89e5b5
  Author: Lucas Ramirez <lucas.rami at proton.me>
  Date:   2026-06-09 (Tue, 09 Jun 2026)

  Changed paths:
    M llvm/include/llvm/CodeGen/Rematerializer.h
    M llvm/lib/CodeGen/Rematerializer.cpp
    M llvm/unittests/CodeGen/RematerializerTest.cpp

  Log Message:
  -----------
  Change rollback method to reduce tracking need


Compare: https://github.com/llvm/llvm-project/compare/69e176310e4f...d6b5e8f71674

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list