[all-commits] [llvm/llvm-project] bccd1b: [StringMap] Invalidate iterators in remove() (#202...

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bccd1b9cb744e5dd96ee59baa4bf4583457feea3
      https://github.com/llvm/llvm-project/commit/bccd1b9cb744e5dd96ee59baa4bf4583457feea3
  Author: Fangrui Song <i at maskray.me>
  Date:   2026-06-09 (Tue, 09 Jun 2026)

  Changed paths:
    M llvm/include/llvm/ADT/StringMap.h
    M llvm/lib/Transforms/IPO/StripSymbols.cpp
    M llvm/unittests/ADT/StringMapTest.cpp

  Log Message:
  -----------
  [StringMap] Invalidate iterators in remove() (#202520)

erase() bumps the epoch to invalidate iterators (#202237), but the
lower-level remove() — which detaches an entry without destroying it,
used
by ValueSymbolTable via Value::setName() — did not. Move the
incrementEpoch() into remove() so remove-while-iterating fails fast
under
LLVM_ENABLE_ABI_BREAKING_CHECKS too.

Aided by Claude Opus 4.8



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications