[all-commits] [llvm/llvm-project] 6c6338: [Frontend][Offloading] Restore silent ignore for n...

[Alexey Bader via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6c6338b3438704cddc1cf3bc6676316856b64907
      https://github.com/llvm/llvm-project/commit/6c6338b3438704cddc1cf3bc6676316856b64907
  Author: Alexey Bader <alexey.bader at intel.com>
  Date:   2026-06-08 (Mon, 08 Jun 2026)

  Changed paths:
    M clang/tools/clang-sycl-linker/ClangSYCLLinker.cpp
    M llvm/lib/Frontend/Offloading/ArchiveLinker.cpp

  Log Message:
  -----------
  [Frontend][Offloading] Restore silent ignore for non-existing input files in nvlink (#202352) (#202403)

Partially revert commit
https://github.com/llvm/llvm-project/commit/a0ccab35110951afc9adc5d7dc733ba8c58cf3f9
to restore
the original behavior of silently skipping non-existent positional input
files
in resolveArchiveMembers(), while preserving strict validation in
clang-sycl-linker.

Background:
The original commit added error reporting for non-existent input files
in the
shared resolveArchiveMembers() function to catch genuine user errors.
However,
this broke clang-nvlink-wrapper when unrecognized options were misparsed
as
input files (e.g., "relro" from "-z relro" before the -z option was
properly
declared in NVLinkOpts.td).

Temporary solution:
- Restore the silent skip behavior in resolveArchiveMembers() for
positional
  input files that don't exist or are directories
- Move the input validation to clang-sycl-linker's getInput() function,
where
strict checking is appropriate for SYCL's more controlled linking
environment
- This preserves the existing test expectations:
  * clang-nvlink-wrapper silently ignores non-existent inputs
  * clang-sycl-linker reports "input file not found" errors

See discussion:
https://github.com/llvm/llvm-project/pull/201253#discussion_r3364244664
and comment
https://github.com/llvm/llvm-project/pull/201253#issuecomment-4651284736.

Co-Authored-By: Claude



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications