[all-commits] [llvm/llvm-project] 1d8491: [lldb][NativePDB] Remove uses of cantFail in AST b...

[Nerixyz via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1d84916abda575472652611ae4cedafc50433b3c
      https://github.com/llvm/llvm-project/commit/1d84916abda575472652611ae4cedafc50433b3c
  Author: Nerixyz <nerixdev at outlook.de>
  Date:   2026-06-08 (Mon, 08 Jun 2026)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilderClang.cpp
    M lldb/source/Plugins/SymbolFile/NativePDB/PdbSymUid.cpp
    M lldb/source/Plugins/SymbolFile/NativePDB/PdbSymUid.h

  Log Message:
  -----------
  [lldb][NativePDB] Remove uses of cantFail in AST builder (#200452)

As a continuation of #187158, this removes uses of `llvm::cantFail` and
replaces them with logs and early returns.

The motivation for this is the PDB of the
[ExprLanguageNote.test](https://github.com/llvm/llvm-project/blob/c241374079f12aabe5d1db5133cb5d924a3cc1d6/lldb/test/Shell/Expr/TestExprLanguageNote.test).
It's incrementally linked (if the built clang uses link.exe by default).
After some amount of checkouts + rebuilds, the PDB gets (semantically)
corrupted such that some type indices point to incorrect records. While
this is a bug in the MSVC linker, we shouldn't crash if we get these
inputs.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications