[all-commits] [llvm/llvm-project] 94c0e6: [libc++][locale] Applied `[[nodiscard]]` (#200726)

[A. Jiang via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 94c0e6fb2536cb2c0dbd205fadd4a8e929388b1a
      https://github.com/llvm/llvm-project/commit/94c0e6fb2536cb2c0dbd205fadd4a8e929388b1a
  Author: A. Jiang <de34 at live.cn>
  Date:   2026-06-03 (Wed, 03 Jun 2026)

  Changed paths:
    M libcxx/include/__locale
    M libcxx/include/__locale_dir/messages.h
    M libcxx/include/__locale_dir/money.h
    M libcxx/test/libcxx/localization/locales/use_facet.abort.pass.cpp
    A libcxx/test/libcxx/localization/nodiscard.verify.cpp

  Log Message:
  -----------
  [libc++][locale] Applied `[[nodiscard]]` (#200726)

`[[nodiscard]]` should be applied to functions where discarding the
return value is most likely a correctness issue.

- https://libcxx.llvm.org/CodingGuidelines.html
- https://wg21.link/localization

Remarks:
- Virtual functions are not marked `[[nodiscard]]` because they are not
expected to be directly called by users.
- `messages::open` is marked `[[nodiscard]]` because it is logically
similar to `operator new` and its friends.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications