[all-commits] [llvm/llvm-project] 059708: [lldb] Skip libc++ category tests on Darwin when n...

[Med Ismail Bennani via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0597087c44e493610d3f96608bef46e721201af6
      https://github.com/llvm/llvm-project/commit/0597087c44e493610d3f96608bef46e721201af6
  Author: Med Ismail Bennani <ismail at bennani.ma>
  Date:   2026-06-01 (Mon, 01 Jun 2026)

  Changed paths:
    M lldb/CMakeLists.txt
    M lldb/packages/Python/lldbsuite/test/dotest.py
    M lldb/test/CMakeLists.txt

  Log Message:
  -----------
  [lldb] Skip libc++ category tests on Darwin when no in-tree libc++ is built (#199262)

`canRunLibcxxTests()` previously short-circuited with "libc++ always
present" for all Darwin targets, meaning the "libc++" test category was
never skipped on macOS — even when `LLDB_HAS_LIBCXX` is `OFF` and no
`--libcxx-include-dir` / `--libcxx-library-dir` are passed to dotest.
The tests would silently run against the system libc++ instead of an
in-tree build, producing results inconsistent with what the suite is
designed to validate.

This fixes `canRunLibcxxTests()` to apply the same `libcxx_include_dir`
/ `libcxx_library_dir` guard on `Darwin` that `Linux` already uses. When
those dirs are absent (i.e. no in-tree libc++ was built), the function
returns `False` and `checkLibcxxSupport()` appends `libc++` to
`skip_categories` — skipping those tests exactly as Linux does.

On the CMake side, the `SEND_ERROR` for `LLDB_HAS_LIBCXX=OFF` is
downgraded to a `WARNING` so downstreams that intentionally skip the
runtimes build can keep `LLDB_INCLUDE_TESTS=ON` for the tests they
actually want to run. The warning is also gated on the new
`LLDB_ENABLE_LIBCXX_TESTS` option (default `ON`): setting it to OFF
acknowledges the deliberate choice and silences the warning without
requiring either an in-tree libc++ build or disabling all tests.

Signed-off-by: Med Ismail Bennani <ismail at bennani.ma>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications