[all-commits] [llvm/llvm-project] e5ab4f: [lldb] Fix CommandInterpreter::GetExecutionContext...

[Pavel Labath via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e5ab4f8a1f766febdc65ce89c00dec85393cfd68
      https://github.com/llvm/llvm-project/commit/e5ab4f8a1f766febdc65ce89c00dec85393cfd68
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2026-06-01 (Mon, 01 Jun 2026)

  Changed paths:
    M lldb/source/Interpreter/CommandInterpreter.cpp
    M lldb/test/API/python_api/interpreter/TestCommandInterpreterAPI.py
    R lldb/test/Shell/Commands/process-attach-dummy.test

  Log Message:
  -----------
  [lldb] Fix CommandInterpreter::GetExecutionContext (#199922)

Following up Jonas's comment in #198949, this patch changes the function
to not ignore the override context in the adopt_dummy_target=false case.

However, I don't implement Jonas's suggestion exactly either. Instead of
"bypassing" the override context if it contains the dummy target, this
patch returns an empty context instead. I think this makes more sense,
as the intention of the user may very well have been to run the command
in the context of the dummy target. The test suite has no opinion either
way, but this is sufficient to fix the regression that #198949 was
trying to fix.

I also delete the test added in that PR, as the tests in this patch
cover more cases, and the test has the potential of interfering with
another process/test running on the same system.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications