[all-commits] [llvm/llvm-project] 58dff9: [llvm-offload-binary] Fix test failures on z/OS by...

Zibi Sarbinowski via All-commits all-commits at lists.llvm.org
Thu May 28 14:59:15 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 58dff928280641f764fd08e421ee8a707f586f2d
      https://github.com/llvm/llvm-project/commit/58dff928280641f764fd08e421ee8a707f586f2d
  Author: Zibi Sarbinowski <zibi at ca.ibm.com>
  Date:   2026-05-28 (Thu, 28 May 2026)

  Changed paths:
    A llvm/test/tools/llvm-offload-binary/llvm-offload-binary-malformed.ll
    M llvm/test/tools/llvm-offload-binary/llvm-offload-binary.ll

  Log Message:
  -----------
  [llvm-offload-binary] Fix test failures on z/OS by splitting malformed tests (#200258)

## Summary
This PR fixes test failures in `llvm-offload-binary.ll` on z/OS (and
potentially other EBCDIC platforms) by splitting the malformed file
tests into a separate test file.

## Problem
The test was failing on z/OS because it uses `printf` with octal escape
sequences to create malformed binary test data:
```bash
printf "\020\377\020\255\012" > %t9
```

On z/OS, the shell's I/O redirection performs automatic EBCDIC-to-ASCII
translation on the output from `printf`. This means the binary data
written to the file gets translated, resulting in different bytes than
intended. The malformed test data is therefore not created correctly,
causing `llvm-offload-binary` to fail in unexpected ways or not produce
the expected error messages.

## Benefits of this solution
- Main test file now passes on all platforms including z/OS
- Malformed file error handling tests are preserved for ASCII-based
systems
- Clear separation of concerns between standard tests and
platform-specific tests
- No loss of test coverage on supported platforms



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list