[all-commits] [llvm/llvm-project] 61b5b0: [libc] Move fixed buffer GPU test to an integratio...

[Nick Sarnie via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 61b5b08623e8457e28bce2984593632a9774be96
      https://github.com/llvm/llvm-project/commit/61b5b08623e8457e28bce2984593632a9774be96
  Author: Nick Sarnie <nick.sarnie at intel.com>
  Date:   2026-05-28 (Thu, 28 May 2026)

  Changed paths:
    M libc/test/integration/src/__support/GPU/CMakeLists.txt

  Log Message:
  -----------
  [libc] Move fixed buffer GPU test to an integration test (#200042)

Move the `fixedbuffer` GPU test to an integration test.

libc tests are intended to be GTest style tests written with the normal
`TEST(Suite, Test)` GTest macros. Example
[here](https://github.com/llvm/llvm-project/blob/main/libc/test/include/SignbitTest.h#L32).

This test has its own `main` which ends up causing a `main multiple
definitions` linker error when compiling for SPIR-V (work in progress).
I'm not sure why this error doesn't occur for AMDGPU, probably the fact
we have to compile with a ton less compile/linker flags for SPIR-V and
one of them hides the issue.

Specifically the fix is that we don't link against
`libc/test/UnitTest/CMakeFiles/LibcTest.hermetic.dir/LibcTestMain.cpp.o`
which has its own main which conflicts with the one defined in the test.

All other tests in this directory are integration tests too.

A quick check of other uses of the `TEST_MAIN` macro also showed them
using `add_integration_test` and not `add_libc_test`.

Signed-off-by: Nick Sarnie <nick.sarnie at intel.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications