[all-commits] [llvm/llvm-project] 787048: [Verifier] Use worklist to verify metadata (#196461)

[Aiden Grossman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 787048a6c1e68afd090cf8261ff948646d5f61c2
      https://github.com/llvm/llvm-project/commit/787048a6c1e68afd090cf8261ff948646d5f61c2
  Author: Aiden Grossman <aidengrossman at google.com>
  Date:   2026-05-08 (Fri, 08 May 2026)

  Changed paths:
    M llvm/lib/IR/Verifier.cpp
    M llvm/unittests/IR/VerifierTest.cpp

  Log Message:
  -----------
  [Verifier] Use worklist to verify metadata (#196461)

This patch switches from using recursive descent to verify metadata to
using a worklist. This change is motivated by the fact that we ran into
some stackoverflows in this code while loading some reasonably large
bitcode modules from an internal server application (i.e., real world
code) within fibers that have somewhat limited stack space. We of course
can get around this by just increasing the stack limit of the fibers,
but this seemed easy enough and the proper way to do things.

This implementation is mine, but I did a preliminary implementation
using Gemini inside of Windsurf.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications