[all-commits] [llvm/llvm-project] 58dc52: [clang] correctly handle +/- features when matchin...

Florian Mayer via All-commits all-commits at lists.llvm.org
Wed May 6 13:21:58 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 58dc52bcf08d93c8c1583fc4a5e38b24ef357b8a
      https://github.com/llvm/llvm-project/commit/58dc52bcf08d93c8c1583fc4a5e38b24ef357b8a
  Author: Florian Mayer <fmayer at google.com>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M clang/lib/Serialization/ASTReader.cpp
    M clang/test/Modules/merge-target-features.cpp

  Log Message:
  -----------
  [clang] correctly handle +/- features when matching modules (#195743)

By sorting and then comparing, we made +sse2 -sse2 equal to
-sse2 +sse2, where the former has sse2 disabled, and the latter
enabled. I verified this is actually the case by compiling the
following:

```
 #ifdef __SSE2__
  #error X
 #endif
```



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list