[all-commits] [llvm/llvm-project] 0059df: [lldb] Do not refcount breakpoints in lldb-server ...

[Pavel Labath via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0059df2a5b53c31f3eb53147a193af9329f7b10d
      https://github.com/llvm/llvm-project/commit/0059df2a5b53c31f3eb53147a193af9329f7b10d
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M lldb/include/lldb/Host/common/NativeProcessProtocol.h
    M lldb/source/Host/common/NativeProcessProtocol.cpp
    M lldb/test/API/functionalities/multi-breakpoint/TestMultiBreakpoint.py

  Log Message:
  -----------
  [lldb] Do not refcount breakpoints in lldb-server (#195858)

We did not say so explictly, but I'd argue that via #195815, we are
supporting stubs which do not refcount breakpoints. In these stubs the
set/clear breakpoint packets are idempotent:
- setting a breakpoint for the second time is a no-op (returns OK)
- clearing a breakpoint clears it, regardless of how many times it has
been set
- clearing a non-existent breakpoint (either because it was already
cleared, or because it was never set) returns an error

This makes lldb-server one of those stubs, which makes the code slightly
simpler, but more importantly, ensures we do not regress this behavior.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications