[all-commits] [llvm/llvm-project] 6c25b2: [OMPIRBuilder] Use correct API to get filename. (#...

[Abid Qadeer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6c25b20a51263f312f6a7a67da6700e9aed8b3a8
      https://github.com/llvm/llvm-project/commit/6c25b20a51263f312f6a7a67da6700e9aed8b3a8
  Author: Abid Qadeer <haqadeer at amd.com>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
    M llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp

  Log Message:
  -----------
  [OMPIRBuilder] Use correct API to get filename. (#195866)

Fix incorrect OpenMP source location in ident strings (e.g. showing
"FIRModule" instead of the real source file for Flang).

This addresses issue #195333 (filename part): we were deriving the file
path from `DIFile::getSource()`, which returns optional *embedded*
source contents, not the path/name of the file on disk. It usually
returns `std::nullopt`, so the code fell back to the LLVM module name
(`M.getName()`), which is often "FIRModule" for FIR lowering.

This issue is a regression of D85938 (9240e48a588c) which switched from
`DILocation::getFilename()` to `DIFile::getSource()`.

Restore use of the location’s filename (`DILocation::getFilename()`) so
the ident string gets the actual source file name when available.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications