[all-commits] [llvm/llvm-project] e37f42: [AArch64][llvm] Tighten SYSP; don't disassemble in...

Tue May 5 08:50:42 PDT 2026

  Branch: refs/heads/users/jthackray/tighten_sysp_encoding
  Home:   https://github.com/llvm/llvm-project
  Commit: e37f42b7b6f997dee5e286ba290244ca37dc7c4c
      https://github.com/llvm/llvm-project/commit/e37f42b7b6f997dee5e286ba290244ca37dc7c4c
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M lldb/test/Shell/Commands/command-disassemble-aarch64-color.s
    M lldb/test/Shell/Commands/command-disassemble-aarch64-extensions.s
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AArch64InstrInfo.td
    M llvm/lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
    M llvm/test/MC/AArch64/armv9-sysp-diagnostics.s
    A llvm/test/MC/AArch64/armv9-sysp-invalid.s
    M llvm/test/MC/AArch64/armv9a-sysp.s

  Log Message:
  -----------
  [AArch64][llvm] Tighten SYSP; don't disassemble invalid encodings

Tighten SYSP aliases, so that invalid encodings are disassembled
to `<unknown>`. This is because:

```
  Cn is a 4-bit unsigned immediate, in the range 8 to 9
  Cm is a 4-bit unsigned immediate, in the range 0 to 7
  op1 is a 3-bit unsigned immediate, in the range 0 to 6
  op2 is a 3-bit unsigned immediate, in the range 0 to 7
```

Ensure we check this when disassembling, and also constrain
tablegen for compile-time errors of invalid encodings.

Also adjust the testcases in `armv9-sysp-diagnostics.s` and
`llvm/test/MC/AArch64/armv9a-sysp.s` as they were invalid,
and added a few invalid (outside of range) SYSP-alikes to
test that `<unknown>` is printed

  Commit: b1d8d4fc0fcc3f5698846338a2cd1609fc857b43
      https://github.com/llvm/llvm-project/commit/b1d8d4fc0fcc3f5698846338a2cd1609fc857b43
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AArch64InstrInfo.td

  Log Message:
  -----------
  fixup! Address Marian's PR comments: use imm0_6 predicate

  Commit: 6f9dd5cf712586264d7299f216d967efebb3475b
      https://github.com/llvm/llvm-project/commit/6f9dd5cf712586264d7299f216d967efebb3475b
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
    M llvm/test/MC/AArch64/armv9-sysp-diagnostics.s

  Log Message:
  -----------
  fixup! Templatise bounds checking and improve tests

  Commit: 46568ab82f3efd70bc667fad4d0661f68306997f
      https://github.com/llvm/llvm-project/commit/46568ab82f3efd70bc667fad4d0661f68306997f
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AArch64InstrInfo.td
    M llvm/lib/Target/AArch64/AArch64RegisterInfo.td
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.h
    M llvm/test/MC/AArch64/armv9-sysp-diagnostics.s
    R llvm/test/MC/AArch64/armv9-sysp-invalid.s
    M llvm/test/MC/AArch64/armv9a-sysp.s

  Log Message:
  -----------
  fixup! Remove SYSPxt_XZR and update code to reflect this

  Commit: 5685d3c398d220570a268ed13715e48b67b10da4
      https://github.com/llvm/llvm-project/commit/5685d3c398d220570a268ed13715e48b67b10da4
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
    M llvm/test/MC/AArch64/armv9a-sysp.s

  Log Message:
  -----------
  fixup! Add no-alias tests

  Commit: 54aa850bfc422a872b21e45f21ac7876e5b17e7e
      https://github.com/llvm/llvm-project/commit/54aa850bfc422a872b21e45f21ac7876e5b17e7e
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp
    M llvm/test/MC/AArch64/armv9-sysp-diagnostics.s

  Log Message:
  -----------
  fixup! Address PR comments

  Commit: 48ee08e73184a8be698504ecf9ee0ce5fe3cbbb1
      https://github.com/llvm/llvm-project/commit/48ee08e73184a8be698504ecf9ee0ce5fe3cbbb1
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td

  Log Message:
  -----------
  fixup! Fixes after rebasing following Marian's change

  Commit: 935b473fc9055ff2d5d88794a506a9ff2338537f
      https://github.com/llvm/llvm-project/commit/935b473fc9055ff2d5d88794a506a9ff2338537f
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/test/MC/AArch64/armv9-sysp-diagnostics.s

  Log Message:
  -----------
  fixup! Improve error parsing

  Commit: 1c0f24194b2420f0a498b1db92f46d3a7e116bb5
      https://github.com/llvm/llvm-project/commit/1c0f24194b2420f0a498b1db92f46d3a7e116bb5
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64RegisterInfo.td
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.h
    M llvm/test/MC/AArch64/armv9a-sysp.s

  Log Message:
  -----------
  fixup! Implement Marian's suggestion to implement as XSeqPairsClass + [XZR, XZR]

  Commit: 389ae9087a392e894525381437698e2f8b1f5326
      https://github.com/llvm/llvm-project/commit/389ae9087a392e894525381437698e2f8b1f5326
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp

  Log Message:
  -----------
  fixup! Address PR comment about shortened `sysp` with xzr/xzr

  Commit: 75e74bb0f0ee7faf7029730f711febfc61052fad
      https://github.com/llvm/llvm-project/commit/75e74bb0f0ee7faf7029730f711febfc61052fad
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td

  Log Message:
  -----------
  fixup! Remove superfluous code

  Commit: bb3de908a9b2c7a7986693192b627eff77a2de4d
      https://github.com/llvm/llvm-project/commit/bb3de908a9b2c7a7986693192b627eff77a2de4d
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/test/MC/AArch64/armv9a-tlbip.s

  Log Message:
  -----------
  fixup! Address Carol's PR comments

  Commit: 8b02faf2b7ec706bcb58b49fe3c56aa5f34c23c4
      https://github.com/llvm/llvm-project/commit/8b02faf2b7ec706bcb58b49fe3c56aa5f34c23c4
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M lldb/test/Shell/Commands/command-disassemble-aarch64-color.s
    M lldb/test/Shell/Commands/command-disassemble-aarch64-extensions.s
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AArch64InstrInfo.td
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp
    M llvm/test/MC/AArch64/armv9-sysp-diagnostics.s
    M llvm/test/MC/AArch64/armv9a-sysp.s

  Log Message:
  -----------
  fixup! Update diff because SYSP definition has changed

  Commit: 2cfd384eeef5304f5340791f7fe818ed2aa8096b
      https://github.com/llvm/llvm-project/commit/2cfd384eeef5304f5340791f7fe818ed2aa8096b
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-05-05 (Tue, 05 May 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AArch64InstrInfo.td
    M llvm/lib/Target/AArch64/AArch64RegisterInfo.td
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.h

  Log Message:
  -----------
  fixup! More optimisations spotted by Marian after the specs changed

Compare: https://github.com/llvm/llvm-project/compare/17101b74c923...2cfd384eeef5

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications