[all-commits] [llvm/llvm-project] 043e77: lldb] Fix two issues causing TestEvents.py flakine...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 043e778f85f60b654547f2104bca32fdbed2eafd
      https://github.com/llvm/llvm-project/commit/043e778f85f60b654547f2104bca32fdbed2eafd
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2026-04-27 (Mon, 27 Apr 2026)

  Changed paths:
    M lldb/source/Target/Process.cpp
    M lldb/source/Target/Target.cpp

  Log Message:
  -----------
  lldb] Fix two issues causing TestEvents.py flakiness (#194438)

This PR fixes two issues that contribute to `TestEvents.py` being flaky
in CI:

1. `ProcessEventData::DoOnRemoval` runs the full stop-handling logic
(like `ShouldStop` and `RunStopHooks`) every time an event is consumed
from any listener. When the primary listener consumes an event and then
the shadow listener consumes the same event, the logic runs twice. The
second execution can race with subsequent event processing. Fix this by
incrementing `m_update_state` after the first successful run so
secondary listeners skip the full logic.

2. Target::RunStopHooks updates `m_latest_stop_hook_id` (marking a stop
as "handled") before checking whether any threads have stop reasons. If
the check fails and hooks don't run, the stop ID is already consumed,
preventing hooks from ever running for that stop. Fix this by deferring
the update until we're certain we'll actually run hooks.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications