[all-commits] [llvm/llvm-project] 28e6b4: [clang] fix profiling of pack index expressions

[Matheus Izvekov via All-commits]

  Branch: refs/heads/users/mizvekov/fix-packindexexpr-profile
  Home:   https://github.com/llvm/llvm-project
  Commit: 28e6b46d6b7857fca7bc8fdcccc2c2ec9891ae36
      https://github.com/llvm/llvm-project/commit/28e6b46d6b7857fca7bc8fdcccc2c2ec9891ae36
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2026-04-18 (Sat, 18 Apr 2026)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/lib/AST/StmtProfile.cpp
    M clang/test/SemaCXX/cxx2c-pack-indexing.cpp

  Log Message:
  -----------
  [clang] fix profiling of pack index expressions

This replaces a few incorrect calls of VisitExpr on subcomponents,
which should have been plain `Visit` instead, because the former
just implements the commonality between all kind-specific profile
functions (marking the class kind and visiting children).

So this for example would visit a DeclRefExpr but not actually profile
any of it's properties, like the parameter declaration, so it would fail
to distinguish between DeclRefExps referencing distinct entities.

This also adds a call to record the PackIndexExpr's kind in the profile,
to avoid false positives when comparing expressions with different kinds.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications