[all-commits] [llvm/llvm-project] 5b938b: [CIR] Fix typeinfo linkage and comdat (#192721)

Andy Kaylor via All-commits all-commits at lists.llvm.org
Fri Apr 17 14:17:42 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5b938b8c0366c387c2d03e7db7445dbb3b131f16
      https://github.com/llvm/llvm-project/commit/5b938b8c0366c387c2d03e7db7445dbb3b131f16
  Author: Andy Kaylor <akaylor at nvidia.com>
  Date:   2026-04-17 (Fri, 17 Apr 2026)

  Changed paths:
    M clang/include/clang/CIR/MissingFeatures.h
    M clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp
    M clang/test/CIR/CodeGen/rtti-member-pointer.cpp
    M clang/test/CIR/CodeGen/rtti-qualfn.cpp
    M clang/test/CIR/CodeGenCXX/vtable-linkage.cpp

  Log Message:
  -----------
  [CIR] Fix typeinfo linkage and comdat (#192721)

We weren't properly setting the linkage on typeinfo objects, leading to
multiple definition linking error when typeinfo for a class was
referenced in multiple source files. We had the correct linkage
available in the buildTypeInfo function, but we weren't doing anything
with it. This also prevented us from hitting the diagnostic saying that
we should have set the comdat attribute for the typeinfo. This change
fixes both of those problems.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list