[all-commits] [llvm/llvm-project] 53368b: [CIR] Fix InlineAsmOp roundtrip parse crash on cir...

Vatsal Khosla via All-commits all-commits at lists.llvm.org
Thu Apr 16 10:17:24 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 53368bf9788b58b80405394e2e7554c3e6b6fc65
      https://github.com/llvm/llvm-project/commit/53368bf9788b58b80405394e2e7554c3e6b6fc65
  Author: Vatsal Khosla <95174891+VatsalKhosla at users.noreply.github.com>
  Date:   2026-04-16 (Thu, 16 Apr 2026)

  Changed paths:
    M clang/lib/CIR/CodeGen/CIRGenAsm.cpp
    M clang/lib/CIR/Dialect/IR/CIRDialect.cpp
    M clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
    M clang/test/CIR/IR/inline-asm.cir

  Log Message:
  -----------
  [CIR] Fix InlineAsmOp roundtrip parse crash on cir.asm (#186588)

Fix InlineAsmOp parser/printer roundtrip for cir.asm and avoid null
operand_attrs entries that crash alias printing during
--verify-roundtrip.

- Parse attr-dict before optional result arrow to match print order.

- Use non-null sentinel attributes for non-maybe_memory operands and
check UnitAttr explicitly.

- Keep lowering semantics by treating only UnitAttr as maybe_memory
marker.

- Update inline-asm CIR IR test to run with --verify-roundtrip and add
an attr+result coverage case.

Fix https://github.com/llvm/llvm-project/issues/161441



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list