[all-commits] [llvm/llvm-project] ad2bf4: [C++20] [Modules] Write comments in C++20 modules'...

[Chuanqi Xu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ad2bf491badb3c9d58591cf271aff94384e2ede6
      https://github.com/llvm/llvm-project/commit/ad2bf491badb3c9d58591cf271aff94384e2ede6
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2026-04-16 (Thu, 16 Apr 2026)

  Changed paths:
    M clang/lib/Serialization/ASTWriter.cpp
    M clang/unittests/Serialization/CMakeLists.txt
    A clang/unittests/Serialization/CommentsTest.cpp
    R clang/unittests/Serialization/NoCommentsTest.cpp

  Log Message:
  -----------
  [C++20] [Modules] Write comments in C++20 modules' module file (#192398)

Previously we avoid writing the comments in C++20 modules' module file.

But this prevents LSP tools to read the comments in it. Although we
thought to add a new option for it and ask LSP to use the new option,
the cost of comments seems to be low and new option raises complexity,
so I prefer to write comments in C++20 modules' module file by default
now.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications