[all-commits] [llvm/llvm-project] c029ca: [mlir][OpenMP] Move taskloop clauses to the contex...

[Tom Eccles via All-commits]

  Branch: refs/heads/users/tblah/taskloop-allocas-2
  Home:   https://github.com/llvm/llvm-project
  Commit: c029ca607548aa4199b228d8b449844d8491f840
      https://github.com/llvm/llvm-project/commit/c029ca607548aa4199b228d8b449844d8491f840
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2026-04-07 (Tue, 07 Apr 2026)

  Changed paths:
    M flang/lib/Lower/OpenMP/OpenMP.cpp
    M flang/lib/Optimizer/Analysis/AliasAnalysis.cpp
    M flang/test/Integration/OpenMP/taskloop-alloca-placement.f90
    M flang/test/Lower/OpenMP/if-clause.f90
    M flang/test/Lower/OpenMP/implicit-dsa.f90
    M flang/test/Lower/OpenMP/masked_taskloop.f90
    M flang/test/Lower/OpenMP/parallel-masked-taskloop.f90
    M flang/test/Lower/OpenMP/taskloop-cancel.f90
    M flang/test/Lower/OpenMP/taskloop-collapse.f90
    M flang/test/Lower/OpenMP/taskloop-grainsize.f90
    M flang/test/Lower/OpenMP/taskloop-inreduction.f90
    M flang/test/Lower/OpenMP/taskloop-numtasks.f90
    M flang/test/Lower/OpenMP/taskloop-reduction.f90
    M flang/test/Lower/OpenMP/taskloop.f90
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
    M mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
    M mlir/lib/Dialect/OpenMP/Transforms/MarkDeclareTarget.cpp
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    M mlir/test/Conversion/OpenMPToLLVM/convert-to-llvmir.mlir
    M mlir/test/Dialect/OpenMP/invalid.mlir
    M mlir/test/Dialect/OpenMP/ops.mlir
    M mlir/test/Target/LLVMIR/openmp-taskloop-cancel.mlir
    M mlir/test/Target/LLVMIR/openmp-taskloop-cancellation-point.mlir
    M mlir/test/Target/LLVMIR/openmp-taskloop-collapse.mlir
    M mlir/test/Target/LLVMIR/openmp-taskloop-context-alloca.mlir
    M mlir/test/Target/LLVMIR/openmp-taskloop-final.mlir
    M mlir/test/Target/LLVMIR/openmp-taskloop-grainsize.mlir
    M mlir/test/Target/LLVMIR/openmp-taskloop-if.mlir
    M mlir/test/Target/LLVMIR/openmp-taskloop-mergeable.mlir
    M mlir/test/Target/LLVMIR/openmp-taskloop-no-context-struct.mlir
    M mlir/test/Target/LLVMIR/openmp-taskloop-nogroup.mlir
    M mlir/test/Target/LLVMIR/openmp-taskloop-num_tasks.mlir
    M mlir/test/Target/LLVMIR/openmp-taskloop-priority.mlir
    M mlir/test/Target/LLVMIR/openmp-taskloop-untied.mlir
    M mlir/test/Target/LLVMIR/openmp-taskloop.mlir
    M mlir/test/Target/LLVMIR/openmp-todo.mlir

  Log Message:
  -----------
  [mlir][OpenMP] Move taskloop clauses to the context op

The clauses are implemented when lowering the context op (which
generates the runtime calls, and handles the outlining of the task
function: including privatization etc). Therefore I thought it made more
sense to put the clauses on this operation rather than on the wrapped
loop.

RFC: https://discourse.llvm.org/t/rfc-openmp-alloca-placement-for-openmp-loop-wrappers/89512/7

Patch 2/3


  Commit: 13362712bcf79407246f99bec818e14e00762170
      https://github.com/llvm/llvm-project/commit/13362712bcf79407246f99bec818e14e00762170
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2026-04-07 (Tue, 07 Apr 2026)

  Changed paths:
    M flang/lib/Lower/OpenMP/OpenMP.cpp
    M mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp

  Log Message:
  -----------
  Address review comments: mark unused param and move var decl

- Mark the unused 'clauses' parameter in TaskloopOp::build with
  [[maybe_unused]]
- Move the declaration of 'wrapperClauseOps' in genStandaloneTaskloop
  to immediately before its first use

Assisted-by: Copilot, Claude Sonnet 4.6


  Commit: 5416beb1c2afa044e7ff72397e882de6009b670f
      https://github.com/llvm/llvm-project/commit/5416beb1c2afa044e7ff72397e882de6009b670f
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2026-04-07 (Tue, 07 Apr 2026)

  Changed paths:
    M mlir/test/Target/LLVMIR/openmp-taskloop-bounds-cast.mlir

  Log Message:
  -----------
  Fix new test again


  Commit: 54af0a7b8d1f09eb9325a4b2437e368d02e605af
      https://github.com/llvm/llvm-project/commit/54af0a7b8d1f09eb9325a4b2437e368d02e605af
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2026-04-07 (Tue, 07 Apr 2026)

  Changed paths:
    M mlir/test/Target/LLVMIR/openmp-taskloop-outer-bounds.mlir

  Log Message:
  -----------
  Fix new test


  Commit: 2d5aab520b49d97afe82fb4017bf70e73122cf88
      https://github.com/llvm/llvm-project/commit/2d5aab520b49d97afe82fb4017bf70e73122cf88
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2026-04-07 (Tue, 07 Apr 2026)

  Changed paths:
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td

  Log Message:
  -----------
  Fix nit


  Commit: 54f57d2fc4eff4d3250655a58bfaac21eef70c22
      https://github.com/llvm/llvm-project/commit/54f57d2fc4eff4d3250655a58bfaac21eef70c22
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2026-04-07 (Tue, 07 Apr 2026)

  Changed paths:
    M flang/lib/Lower/OpenMP/OpenMP.cpp

  Log Message:
  -----------
  Don't create unnessecary block arguments


Compare: https://github.com/llvm/llvm-project/compare/96ca63f697b2...54f57d2fc4ef

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications