[all-commits] [llvm/llvm-project] 8ab7b3: [OpenMP][test] Remove %flags-use-compiler-omp-h (#...

[Michael Kruse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8ab7b37e749f4ab7c4536fec82cb813586d9f334
      https://github.com/llvm/llvm-project/commit/8ab7b37e749f4ab7c4536fec82cb813586d9f334
  Author: Michael Kruse <llvm-project at meinersbur.de>
  Date:   2026-03-27 (Fri, 27 Mar 2026)

  Changed paths:
    M openmp/cmake/OpenMPTesting.cmake
    M openmp/runtime/test/CMakeLists.txt
    M openmp/runtime/test/lit.cfg
    M openmp/runtime/test/lit.site.cfg.in
    M openmp/runtime/test/tasking/omp50_taskdep_depobj.c

  Log Message:
  -----------
  [OpenMP][test] Remove %flags-use-compiler-omp-h (#188789)

With the standalone and project builds removed,
`OPENMP_TEST_COMPILER_HAS_OMP_H`/`config.test_compiler_has_omp_h` is set
to constant 1, which causes the `config.omp_header_directory` search
path NOT to be added to `%flags-use-compiler-omp-h`, causing the system
`omp.h` used, or the only test actually using it
(`omp50_taskdep_depobj.c`) failing if that one is not available.

The intention of `OPENMP_TEST_COMPILER_HAS_OMP_H` was to use gcc's
`omp.h` which declares `omp_depend_t` differently than our `omp.h`
(https://reviews.llvm.org/D108790). Using `OPENMP_TEST_C_COMPILER=gcc`
was used to test libomp's GOMP compatibility layer, but testing it is
currently unmaintained and has no buildbot (60 failing tests out of 389
with gcc-13, not including OMPD and OMPT). If updating testing for GOMP,
then gcc's own `omp.h` must be used for all tests: using the GOMP ABI
requires using GOMP's `omp.h`.

Closes: #187879



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications