[all-commits] [llvm/llvm-project] da5d42: [MLIR][TableGen] Make optional enum parser not con...

[Robert Konicar via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: da5d4214bc89021558311055bb5cd905a78020bd
      https://github.com/llvm/llvm-project/commit/da5d4214bc89021558311055bb5cd905a78020bd
  Author: Robert Konicar <rkonicar at mail.muni.cz>
  Date:   2026-03-23 (Mon, 23 Mar 2026)

  Changed paths:
    M mlir/include/mlir/IR/OpImplementation.h
    M mlir/lib/AsmParser/AsmParserImpl.h
    M mlir/test/IR/enum-attr-roundtrip.mlir
    M mlir/test/lib/Dialect/Test/TestEnumDefs.td
    M mlir/test/lib/Dialect/Test/TestOpsSyntax.td
    M mlir/tools/mlir-tblgen/EnumsGen.cpp

  Log Message:
  -----------
  [MLIR][TableGen] Make optional enum parser not consume the token when it is not matched (#188008)

Previously the optional parser would consume the token even when it
failed to match a value of the enum and prevented parsers later in the
op syntax from having an attempt. This PR changes that so that the token
is consumed only when the parsing succeeds. This change is made to the
emitted `FieldParser<std::optional<T>>` for enums.

This, for example, allows having a simple list of default valued props
in the assembly format without needing decorations around them. This
mimics the behaviour that is emitted for `DefaultValuedAttribute` when
it is used with `EnumAttr`.

This PR also adds `parseOptionalString` variant with an allow-list
argument as `parseOptionalKeyword` has and adds
`parseOptionalKeywordOrString` allow-list variant which combines these
two into a single utility wrapper. These methods do not consume the
token unless it is from the allow-list.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications