[all-commits] [llvm/llvm-project] 629eda: [clang][Driver][Darwin] Optionally use xcselect to...

[Carlo Cabrera via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 629edaf67844c01db37d6bb9e04f04ecf8447fc5
      https://github.com/llvm/llvm-project/commit/629edaf67844c01db37d6bb9e04f04ecf8447fc5
  Author: Carlo Cabrera <github at carlo.cab>
  Date:   2026-03-14 (Sat, 14 Mar 2026)

  Changed paths:
    M clang/CMakeLists.txt
    M clang/include/clang/Config/config.h.cmake
    M clang/lib/Driver/CMakeLists.txt
    M clang/lib/Driver/ToolChains/Darwin.cpp
    M clang/test/CMakeLists.txt
    A clang/test/Driver/darwin-ld-platform-version-macos-nosdk.c
    M clang/test/Driver/darwin-ld-platform-version-macos.c
    A clang/test/Driver/xcselect.c
    M clang/test/lit.cfg.py
    M clang/test/lit.site.cfg.py.in

  Log Message:
  -----------
  [clang][Driver][Darwin] Optionally use xcselect to find macOS SDK (#119670)

This is a scaled down version of https://reviews.llvm.org/D136315.

The intent is largely the same as before[^1], but I've scaled down the
scope to try to avoid the issues that the previous patch caused:
- the changes are now opt-in based on enabling `CLANG_USE_XCSELECT`
- this only works when targeting macOS on a macOS host (this is the only
case supported by `libxcselect`[^2])
- calling `libxcselect` is done only when the target is `*-apple-macos*`
to avoid breaking many tests

Another reason to leave this as opt-in for now is that there are some
bugs in libxcselect that need fixing before it is safe to use by default
for all users. This has been reported to Apple as FB16081077.

[^1]: See also https://reviews.llvm.org/D109460 and #45225.
[^2]: https://developer.apple.com/documentation/xcselect?language=objc



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications