[all-commits] [llvm/llvm-project] 57a6e6: [mlir] avoid comparing char with `~0x00` literal. ...
Chenguang Wang via All-commits
all-commits at lists.llvm.org
Fri Mar 13 10:28:10 PDT 2026
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 57a6e6f9ceb292f847f81b4e2c4e2623397ac982
https://github.com/llvm/llvm-project/commit/57a6e6f9ceb292f847f81b4e2c4e2623397ac982
Author: Chenguang Wang <w3cing at gmail.com>
Date: 2026-03-13 (Fri, 13 Mar 2026)
Changed paths:
M mlir/lib/IR/BuiltinDialectBytecode.cpp
Log Message:
-----------
[mlir] avoid comparing char with `~0x00` literal. (#186441)
Introduced in #186221. This is actually incorrect; when we compare
char with int, due to arithmetic conversion, the char may be sign
extended or not (depending on whether `char` is signed), so the
comparison does not always have the expected behavior. But the
RHS will always be 0xFFFFFFFF.
To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications
More information about the All-commits
mailing list