[all-commits] [llvm/llvm-project] c47e89: [AArch64][llvm] Tighten SYSP; don't disassemble in...

[Jonathan Thackray via All-commits]

  Branch: refs/heads/users/jthackray/tighten_sysp_encoding
  Home:   https://github.com/llvm/llvm-project
  Commit: c47e8932766c0bfa049fef72c565f9f7e64174c2
      https://github.com/llvm/llvm-project/commit/c47e8932766c0bfa049fef72c565f9f7e64174c2
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-03-11 (Wed, 11 Mar 2026)

  Changed paths:
    M lldb/test/Shell/Commands/command-disassemble-aarch64-color.s
    M lldb/test/Shell/Commands/command-disassemble-aarch64-extensions.s
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AArch64InstrInfo.td
    M llvm/lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
    M llvm/test/MC/AArch64/armv9-sysp-diagnostics.s
    A llvm/test/MC/AArch64/armv9-sysp-invalid.s
    M llvm/test/MC/AArch64/armv9a-sysp.s

  Log Message:
  -----------
  [AArch64][llvm] Tighten SYSP; don't disassemble invalid encodings

Tighten SYSP aliases, so that invalid encodings are disassembled
to `<unknown>`. This is because:

```
  Cn is a 4-bit unsigned immediate, in the range 8 to 9
  Cm is a 4-bit unsigned immediate, in the range 0 to 7
  op1 is a 3-bit unsigned immediate, in the range 0 to 6
  op2 is a 3-bit unsigned immediate, in the range 0 to 7
```

Ensure we check this when disassembling, and also constrain
tablegen for compile-time errors of invalid encodings.

Also adjust the testcases in `armv9-sysp-diagnostics.s` and
`llvm/test/MC/AArch64/armv9a-sysp.s` as they were invalid,
and added a few invalid (outside of range) SYSP-alikes to
test that `<unknown>` is printed


  Commit: 41601f0679a7b33001a0bfab7838445e8b7d61a7
      https://github.com/llvm/llvm-project/commit/41601f0679a7b33001a0bfab7838445e8b7d61a7
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-03-11 (Wed, 11 Mar 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AArch64InstrInfo.td

  Log Message:
  -----------
  fixup! Address Marian's PR comments: use imm0_6 predicate


  Commit: 5e7ae1dd529f139c12dbb5330df03e98f3627f49
      https://github.com/llvm/llvm-project/commit/5e7ae1dd529f139c12dbb5330df03e98f3627f49
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-03-11 (Wed, 11 Mar 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
    M llvm/test/MC/AArch64/armv9-sysp-diagnostics.s

  Log Message:
  -----------
  fixup! Templatise bounds checking and improve tests


  Commit: a689652f9aef6b86ac91c3f02f3788d3477b13ea
      https://github.com/llvm/llvm-project/commit/a689652f9aef6b86ac91c3f02f3788d3477b13ea
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-03-11 (Wed, 11 Mar 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AArch64InstrInfo.td
    M llvm/lib/Target/AArch64/AArch64RegisterInfo.td
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.h
    M llvm/test/MC/AArch64/armv9-sysp-diagnostics.s
    R llvm/test/MC/AArch64/armv9-sysp-invalid.s
    M llvm/test/MC/AArch64/armv9a-sysp.s

  Log Message:
  -----------
  fixup! Remove SYSPxt_XZR and update code to reflect this


  Commit: a3ad37fd2b491877127da10e6505a1d1a8af5888
      https://github.com/llvm/llvm-project/commit/a3ad37fd2b491877127da10e6505a1d1a8af5888
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-03-11 (Wed, 11 Mar 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
    M llvm/test/MC/AArch64/armv9a-sysp.s

  Log Message:
  -----------
  fixup! Add no-alias tests


Compare: https://github.com/llvm/llvm-project/compare/81e4fcd3949a...a3ad37fd2b49

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications