[all-commits] [llvm/llvm-project] 3829fd: [mlir][Pass] Report error when passing options to ...

John Paul Jepko via All-commits all-commits at lists.llvm.org
Tue Mar 10 13:44:31 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3829fdb8afaa4a54d7210a52047e8acb2cf6aa5b
      https://github.com/llvm/llvm-project/commit/3829fdb8afaa4a54d7210a52047e8acb2cf6aa5b
  Author: John Paul Jepko <jpjepko at umich.edu>
  Date:   2026-03-10 (Tue, 10 Mar 2026)

  Changed paths:
    M mlir/lib/Pass/PassRegistry.cpp
    M mlir/test/Pass/invalid-pass.mlir

  Log Message:
  -----------
  [mlir][Pass] Report error when passing options to pipelines via shorthand syntax (#185738)

When passing options to a pass pipeline that doesn't accept options,
mlir-opt exits with error code 1, but prints no error message when using
shorthand CLI syntax:

```
# Silent failure (no error message):
$ mlir-opt --tosa-to-linalg-pipeline=foo /dev/null
$ echo $?
1

# Same pipeline via --pass-pipeline syntax reports error:
$ mlir-opt --pass-pipeline='builtin.module(tosa-to-linalg-pipeline{foo})' /dev/null
<unknown>:0: error: failed to add `tosa-to-linalg-pipeline` with options `foo`
```

This PR adds replaces the silent call to `failure` with `errorHandler`
in `PassPipelineCLParser::addToPipeline`, matching the existing pattern
in `TextualPipeline::addToPipeline`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list