[all-commits] [llvm/llvm-project] 1a23e6: [mlir] Fix assertion crash in test-symbol-uses wit...

[Mehdi Amini via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1a23e643be6b98fce376300e27383c2bf23061b9
      https://github.com/llvm/llvm-project/commit/1a23e643be6b98fce376300e27383c2bf23061b9
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2026-03-06 (Fri, 06 Mar 2026)

  Changed paths:
    M mlir/test/IR/test-symbol-uses.mlir
    M mlir/test/lib/IR/TestSymbolUses.cpp

  Log Message:
  -----------
  [mlir] Fix assertion crash in test-symbol-uses with nested modules (#185069)

The `SymbolUsesPass` walked all nested `SymbolOpInterface` ops in a
module, including those belonging to nested symbol tables (e.g., nested
modules). When an external `func.func` inside a nested module had no
uses in the outer module's body region, it was incorrectly added to
`deadFunctions` for erasure. Since the outer module's `SymbolTable` does
not contain the inner module's symbols, the subsequent
`table.lookup(name)` assertion would fail with:

Assertion `table.lookup(name) && "expected no unknown operations"`
failed.

Fix by only tracking functions that are direct children of the enclosing
module, skipping functions owned by nested symbol tables.

Fixes #60583

Assisted-by: Claude Code



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications