[all-commits] [llvm/llvm-project] ffcb77: [NFC][SPIRV] Extract helper functions in SPIRVEmit...

[Manuel Carrasco via All-commits]

  Branch: refs/heads/users/mgcarrasco/spirv/debug-function-2
  Home:   https://github.com/llvm/llvm-project
  Commit: ffcb7754839e7cb1403c2f7ba8ab8c8039cf4d13
      https://github.com/llvm/llvm-project/commit/ffcb7754839e7cb1403c2f7ba8ab8c8039cf4d13
  Author: Manuel Carrasco <Manuel.Carrasco at amd.com>
  Date:   2026-03-05 (Thu, 05 Mar 2026)

  Changed paths:
    M llvm/lib/Target/SPIRV/SPIRVEmitNonSemanticDI.cpp

  Log Message:
  -----------
  [NFC][SPIRV] Extract helper functions in SPIRVEmitNonSemanticDI

This commit extracts reusable helper functions to improve code
organization and reduce duplication. This is a pure refactoring
that does not change behavior.

These helpers will be used in subsequent commits to refactor
emitGlobalDI and add function-level debug info emission.


  Commit: 4a84fc267ec18c514ad504c14f104b40788e0b45
      https://github.com/llvm/llvm-project/commit/4a84fc267ec18c514ad504c14f104b40788e0b45
  Author: Manuel Carrasco <Manuel.Carrasco at amd.com>
  Date:   2026-03-05 (Thu, 05 Mar 2026)

  Changed paths:
    M llvm/lib/Target/SPIRV/SPIRVEmitNonSemanticDI.cpp

  Log Message:
  -----------
  [NFC][SPIRV] Refactor emitGlobalDI to use helpers and store CompileUnitRegMap

This commit refactors emitGlobalDI() to use the extracted helper
functions and adds CompileUnitRegMap to store DebugCompilationUnit
registers for later lookup by function-level debug info emission.

This prepares for function-level debug info emission which needs
to look up compile units.


  Commit: 7977f6622776d5e18114410f0242dde621f3e712
      https://github.com/llvm/llvm-project/commit/7977f6622776d5e18114410f0242dde621f3e712
  Author: Manuel Carrasco <Manuel.Carrasco at amd.com>
  Date:   2026-03-05 (Thu, 05 Mar 2026)

  Changed paths:
    M llvm/lib/Target/SPIRV/SPIRVEmitNonSemanticDI.cpp

  Log Message:
  -----------
  [review] Simplify module retrieval.


  Commit: 8121e40e66f5d82664f359fb71550f69499f12a2
      https://github.com/llvm/llvm-project/commit/8121e40e66f5d82664f359fb71550f69499f12a2
  Author: Manuel Carrasco <Manuel.Carrasco at amd.com>
  Date:   2026-03-05 (Thu, 05 Mar 2026)

  Changed paths:
    M llvm/lib/Target/SPIRV/SPIRVEmitNonSemanticDI.cpp

  Log Message:
  -----------
  [review] Use ArrayRef<Register> instead of std::initializer_list<Register>


  Commit: 8e02f0aefad984785c779a62fb493e3d00e959c5
      https://github.com/llvm/llvm-project/commit/8e02f0aefad984785c779a62fb493e3d00e959c5
  Author: Manuel Carrasco <Manuel.Carrasco at amd.com>
  Date:   2026-03-05 (Thu, 05 Mar 2026)

  Changed paths:
    M llvm/lib/Target/SPIRV/SPIRVEmitNonSemanticDI.cpp

  Log Message:
  -----------
  [review] Refactor SPIRVEmitNonSemanticDI to reduce container usage


  Commit: a3e729dee0aaae25ce283fa7a0f265fcd8ca4b6c
      https://github.com/llvm/llvm-project/commit/a3e729dee0aaae25ce283fa7a0f265fcd8ca4b6c
  Author: Manuel Carrasco <Manuel.Carrasco at amd.com>
  Date:   2026-03-05 (Thu, 05 Mar 2026)

  Changed paths:
    M llvm/lib/Target/SPIRV/SPIRVEmitNonSemanticDI.cpp

  Log Message:
  -----------
  [review] Simplify CUs collection even further.


  Commit: 9e587726127c3fc51ce234106ea34a5785b4a903
      https://github.com/llvm/llvm-project/commit/9e587726127c3fc51ce234106ea34a5785b4a903
  Author: Manuel Carrasco <Manuel.Carrasco at amd.com>
  Date:   2026-03-05 (Thu, 05 Mar 2026)

  Changed paths:
    M llvm/lib/Target/SPIRV/SPIRVEmitNonSemanticDI.cpp

  Log Message:
  -----------
  [review] Favour range for loops.


  Commit: a1a3a7b6544b52e8b7f41c9c7451c9bb25a8f636
      https://github.com/llvm/llvm-project/commit/a1a3a7b6544b52e8b7f41c9c7451c9bb25a8f636
  Author: Manuel Carrasco <Manuel.Carrasco at amd.com>
  Date:   2026-03-05 (Thu, 05 Mar 2026)

  Changed paths:
    M llvm/lib/Target/SPIRV/SPIRVEmitNonSemanticDI.cpp

  Log Message:
  -----------
  [review] Style comment.


  Commit: cd134d00d5273aaaae9efdba3b1d59503dd0693a
      https://github.com/llvm/llvm-project/commit/cd134d00d5273aaaae9efdba3b1d59503dd0693a
  Author: Manuel Carrasco <Manuel.Carrasco at amd.com>
  Date:   2026-03-05 (Thu, 05 Mar 2026)

  Changed paths:
    M llvm/lib/Target/SPIRV/SPIRVEmitNonSemanticDI.cpp

  Log Message:
  -----------
  [review] Use 64-bits LLT and save instruction set ext in a member variable.


Compare: https://github.com/llvm/llvm-project/compare/5164085b5341...cd134d00d527

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications