[all-commits] [llvm/llvm-project] 041870: [SDAGBuilder] Fix incorrect fcmp+select to minnum/...

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0418700f047950e71b5c94a31f2ed76f976e6090
      https://github.com/llvm/llvm-project/commit/0418700f047950e71b5c94a31f2ed76f976e6090
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2026-03-05 (Thu, 05 Mar 2026)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
    M llvm/lib/Target/NVPTX/NVPTXInstrInfo.td
    M llvm/test/CodeGen/AArch64/arm64-fmax-safe.ll
    M llvm/test/CodeGen/ARM/fp16-vminmaxnm-safe.ll
    M llvm/test/CodeGen/ARM/minnum-maxnum-intrinsics.ll
    M llvm/test/CodeGen/ARM/vminmaxnm-safe.ll
    M llvm/test/CodeGen/X86/avx512-broadcast-unfold.ll
    M llvm/test/CodeGen/X86/sse-minmax.ll

  Log Message:
  -----------
  [SDAGBuilder] Fix incorrect fcmp+select to minnum/maxnum transform (#184590)

minnum/maxnum don't have the correct sNaN semantics, we must convert to
minimumnum/maximumnum instead.

To avoid an NVPTX regression, make it handle fmaximmumnum in one
TableGen pattern.

This is intended as a targeted fix for the miscompile, as the complete
removal of this transform (#93575) appears to be blocked.

Fixes https://github.com/llvm/llvm-project/issues/176624.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications