[all-commits] [llvm/llvm-project] 827254: [HLSL][SPIRV] Fix `faceforward` pattern matcher lo...

[Kaitlin Peng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8272546f6910e78f255830d9592c6926d93be04c
      https://github.com/llvm/llvm-project/commit/8272546f6910e78f255830d9592c6926d93be04c
  Author: Kaitlin Peng <kaitlinpeng at microsoft.com>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M llvm/lib/Target/SPIRV/SPIRVCombinerHelper.cpp

  Log Message:
  -----------
  [HLSL][SPIRV] Fix `faceforward` pattern matcher logic (#183630)

Fixes a logic issue in the `faceforward` pattern matcher in
`SPIRVCombinerHelper.cpp`.
Previously when `mi_match` failed, we would still go through the nested
`Pred == CmpInst::FCMP_OGT || Pred == CmpInst::FCMP_UGT` check. It was
possible that whatever garbage was in Pred could randomly pass this
check and make us continue through the code. This change fixes that
logic issue by returning false as soon as `mi_match` fails.

Likely fixes #177803. Can't confirm since it seems another change has
obscured the crash.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications