[all-commits] [llvm/llvm-project] 753834: [lldb] generalize the GDBRemoteCommunicationClient...

[Matej Košík via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 75383421c1c6b8a33e762b42b83242dbd85e466e
      https://github.com/llvm/llvm-project/commit/75383421c1c6b8a33e762b42b83242dbd85e466e
  Author: Matej Košík <m4tej.kosik at gmail.com>
  Date:   2026-02-24 (Tue, 24 Feb 2026)

  Changed paths:
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp

  Log Message:
  -----------
  [lldb] generalize the GDBRemoteCommunicationClient::GetVContSupported method (#182287)

This is a conservative generalization of the
`GDBRemoteCommunicationClient::GetVContSupported` method so that:
- the new version of this method handles the reply to the `vCont?`
packet the same way as the original version of this method
- the new version of this method can be easily adapted to situation when
the actions are represented by multiple letters.

Imagine that, in addition to the [existing
actions](https://sourceware.org/gdb/current/onlinedocs/gdb.html/Packets.html#vCont-packet):
- `c`
- `C`
- `s`
- `S`
- `t`
- `r`

the other party would also advertise that it supports (e.g.) `sc` action
(meaning e.g. that we can ask the other party to step into microcode).

The new version of this method can be easily adapted to handle such a
case without compromising correct handling of the original actions
represented by single characters.

---------

Co-authored-by: Matej Košík <matej.kosik at codasip.com>
Co-authored-by: Jonas Devlieghere <jonas at devlieghere.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications