[all-commits] [llvm/llvm-project] b33350: [ADT] Fix RadixTree singular iterator use in findO...

Brian Cain via All-commits all-commits at lists.llvm.org
Sat Feb 14 21:10:21 PST 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b33350f5ff3a29508cf3ba69b10683afc378e905
      https://github.com/llvm/llvm-project/commit/b33350f5ff3a29508cf3ba69b10683afc378e905
  Author: Brian Cain <brian.cain at oss.qualcomm.com>
  Date:   2026-02-14 (Sat, 14 Feb 2026)

  Changed paths:
    M llvm/include/llvm/ADT/RadixTree.h

  Log Message:
  -----------
  [ADT] Fix RadixTree singular iterator use in findOrCreate (#181510)

The root node's Key is initialized with default-constructed (singular)
iterators. When findOrCreate calls llvm::mismatch(Key, Curr->Key) on the
first loop iteration where Curr is the root, these singular iterators
are passed to std::mismatch. _GLIBCXX_DEBUG correctly rejects them as
not forming a valid iterator range.

Skip the mismatch when Curr is the root node since its key is
conceptually empty, making the mismatch a no-op.

Fixes a test failure in ADTTests/RadixTreeTypeTest introduced by
5fda2a5d9c1a ("[NFC][ADT] Add RadixTree (#164524)").



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list