[all-commits] [llvm/llvm-project] 0773c8: [lldb] Fix pid_t redefinition on Windows in Script...
rchamala via All-commits
all-commits at lists.llvm.org
Sat Feb 14 09:45:09 PST 2026
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 0773c83e6666ac5cbd4c9b89ebb2e78e7c494821
https://github.com/llvm/llvm-project/commit/0773c83e6666ac5cbd4c9b89ebb2e78e7c494821
Author: rchamala <36907958+rchamala at users.noreply.github.com>
Date: 2026-02-14 (Sat, 14 Feb 2026)
Changed paths:
M lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptInterpreterPythonInterfaces.cpp
Log Message:
-----------
[lldb] Fix pid_t redefinition on Windows in ScriptInterpreterPythonInterfaces (#181493)
## Summary
Include `lldb-python.h` as the first include inside the
`LLDB_ENABLE_PYTHON` block in `ScriptInterpreterPythonInterfaces.cpp`,
matching the pattern used by every other Python interface `.cpp` file in
this directory.
On Windows, `lldb-python.h` defines `NO_PID_T` before including
`Python.h`. This prevents `PosixApi.h` (transitively included via
`lldb-private.h`) from redefining `pid_t` with a conflicting type
(`uint32_t` vs `int`).
The issue was introduced by #181334 (ScriptedSymbolLocator plugin),
which added a new header whose include chain transitively reaches
`PosixApi.h`.
Fixes Windows build failures on lldb-aarch64-windows, lldb-x86_64-win,
and lldb-remote-linux-win.
## Test plan
- [ ] lldb-aarch64-windows build passes
- [ ] lldb-x86_64-win build passes
- [ ] lldb-remote-linux-win build passes
Co-authored-by: Rahul Reddy Chamala <rachamal at meta.com>
To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications
More information about the All-commits
mailing list