[all-commits] [llvm/llvm-project] d406ce: [lldb][macOS] Don't fetch settings in Host, to kee...

[Jason Molenda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d406ce8e20600171b6030c9dcf728a23975c9eaf
      https://github.com/llvm/llvm-project/commit/d406ce8e20600171b6030c9dcf728a23975c9eaf
  Author: Jason Molenda <jmolenda at apple.com>
  Date:   2026-02-13 (Fri, 13 Feb 2026)

  Changed paths:
    M lldb/include/lldb/Core/ModuleList.h
    M lldb/include/lldb/Host/HostInfoBase.h
    M lldb/include/lldb/Host/macosx/HostInfoMacOSX.h
    M lldb/include/lldb/lldb-enumerations.h
    M lldb/source/Core/CoreProperties.td
    M lldb/source/Core/ModuleList.cpp
    M lldb/source/Host/macosx/objcxx/CMakeLists.txt
    M lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm
    M lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformDarwinDevice.cpp
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/source/Plugins/SymbolLocator/DebugSymbols/SymbolLocatorDebugSymbols.cpp
    M lldb/unittests/ObjectFile/MachO/TestObjectFileMachO.cpp

  Log Message:
  -----------
  [lldb][macOS] Don't fetch settings in Host, to keep layering (#181406)

I introduced a dependency from Host on Core without realizing it in an
earlier PR, while adding a setting to disable the new shared cache
binary blob scanning/reading in HostInfoMacOSX, which caused build
problems. Thanks to Alex for figuring out the build failure I caused.

Add a bool to the methods in HostInfoMacOSX, and have the callers (in
Core and various plugins etc) all fetch the
symbols.shared-cache-binary-loading setting from ModuleList, and pass
the result in.

The least obvious part of this is in ProcessGDBRemote where we first
learn the shared cache filepath & uuid, it calls
HostInfoMacOSX::SharedCacheIndexFiles() - this is only called when the
shared cache binary loading is enabled, so I conditionalize the call to
this method based on the setting.

rdar://148939795



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications