[all-commits] [llvm/llvm-project] 320d0b: [NFCI][analyzer] Regularize NodeBuilder classes (#...

[Donát Nagy via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 320d0b5467b9586a188e06dd2620126f5cb99318
      https://github.com/llvm/llvm-project/commit/320d0b5467b9586a188e06dd2620126f5cb99318
  Author: Donát Nagy <donat.nagy at ericsson.com>
  Date:   2026-02-13 (Fri, 13 Feb 2026)

  Changed paths:
    M clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h
    M clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
    M clang/lib/StaticAnalyzer/Core/CoreEngine.cpp
    M clang/lib/StaticAnalyzer/Core/ExprEngine.cpp
    A clang/test/Analysis/indirect-goto-basics.c
    A clang/test/Analysis/switch-basics.c

  Log Message:
  -----------
  [NFCI][analyzer] Regularize NodeBuilder classes (#180960)

This commit removes virtual methods from the `NodeBuilder` class
hierarchy (because they were only relevant for the "enclosing builder"
feature of `StmtNodeBuilder` which was not used anywhere), then moves
the classes `IndirectGotoNodeBuilder` and `SwitchNodeBuilder` into this
hierarchy. (Previously they were independent classes with some
duplicated logic in the `generateNode()`-like functions.)

Updating `SwitchNodeBuilder` is a prerequisite for activating the
`BranchCondition` checkers on the condition of the `switch` statement
because `CheckerContext` requires the presence of a `NodeBuilder`.

Updating `IndirectGotoNodeBuilder` doesn't have any analogous goals --
I'm just doing it for the sake of consistency.

I also added some very basic tests because this area wasn't properly
covered by the old tests.

I'm planning to do more cleanup (e.g. the removal of `StmtNodeBuilder`)
in follow-up commits.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications