[all-commits] [llvm/llvm-project] 5fef36: [LLDB][NativePDB] Use pointer and not pointee size...

Leonard Grey via All-commits all-commits at lists.llvm.org
Thu Feb 12 06:35:50 PST 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5fef36767fe8d852a65ef3a4c020c677bc80799b
      https://github.com/llvm/llvm-project/commit/5fef36767fe8d852a65ef3a4c020c677bc80799b
  Author: Leonard Grey <leonard at leonardgrey.com>
  Date:   2026-02-12 (Thu, 12 Feb 2026)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp

  Log Message:
  -----------
  [LLDB][NativePDB] Use pointer and not pointee size for pointer constants (#180987)

Follow-up from
https://github.com/llvm/llvm-project/pull/180612#pullrequestreview-3780142672

This was introduced in 2af3416618e6 and not fundamentally changed since.
The review (https://reviews.llvm.org/D54452) doesn't mention any
motivation for why we would want the pointee size/signedness here. As
@Nerixyz points out, only a null pointer can be `S_CONSTANT` anyway.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list