[all-commits] [llvm/llvm-project] 20d3aa: [NFC][ELF] Remove redundant and unused file argume...

Jessica Clarke via All-commits all-commits at lists.llvm.org
Mon Feb 9 10:58:05 PST 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 20d3aa944fb5cdbeb7e855fcd0800abd6d4a7842
      https://github.com/llvm/llvm-project/commit/20d3aa944fb5cdbeb7e855fcd0800abd6d4a7842
  Author: Jessica Clarke <jrtc27 at jrtc27.com>
  Date:   2026-02-09 (Mon, 09 Feb 2026)

  Changed paths:
    M lld/ELF/Arch/X86_64.cpp
    M lld/ELF/Target.h
    M lld/ELF/Writer.cpp

  Log Message:
  -----------
  [NFC][ELF] Remove redundant and unused file argument from deleteFallThruJmpInsn (#180540)

This was added in 94317878d826 ("LLD Support for Basic Block Sections")
and was only ever used for getRelocTargetVA. It was always redundant
even back then, as it was always the same as is.file, and so passing it
separately made it confusing and less obvious which file it was
referring to, but 2b5cb1bf628f ("[ELF] getRelocTargetVA: pass Ctx and
Relocation. NFC") removed that one use so it is now completely unused.
Remove it, and if anyone ever finds a need for it, they can just use
is.file like should have been done in the first place.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list