[all-commits] [llvm/llvm-project] 8479c0: [lldb-dap] Remove end line and column from disasse...

[Ebuka Ezike via All-commits]

  Branch: refs/heads/release/22.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 8479c04674ffe146b523a3661ae4cec0cd7deaf4
      https://github.com/llvm/llvm-project/commit/8479c04674ffe146b523a3661ae4cec0cd7deaf4
  Author: Ebuka Ezike <e_ezike at apple.com>
  Date:   2026-02-09 (Mon, 09 Feb 2026)

  Changed paths:
    M lldb/tools/lldb-dap/Handler/DisassembleRequestHandler.cpp

  Log Message:
  -----------
  [lldb-dap] Remove end line and column from disassemble response (#180037)

The end line entry calculated from the instruction's end address is
unreliable and could produce incorrect source ranges. especially if the
instruction spans multiple lines.

We can end in situations where the current end line is the next start
line and the source line is show to the client twice. confusing users
what maps to what.

| With EndLine |
| :------------: |
| <img width="892" height="486" alt="Screenshot 2026-02-05 at 21 37 08"
src="https://github.com/user-attachments/assets/f2fef592-5754-4168-bf93-2baba4742c5d"
/> |

| Without Endline |
| :---------------: |
| <img width="892" height="486" alt="Screenshot 2026-02-05 at 21 59 29"
src="https://github.com/user-attachments/assets/538dd462-9c7f-4483-804c-65fd83b5f2f2"
/>|

 Or the endline is smaller than the startline.
 ```json
 {
  "address": "0x5555555557B4",
  "column": 3,
  "endLine": 2,
  "instruction": "add     rsp, 0x20                ",
  "instructionBytes": "48 83 c4 20",
  "line": 17,
  "location": {
    "name": "test.cpp",
    "path": "/buildbot/test_process/test.cpp"
  }
},
```

(cherry picked from commit bde4754bc48029398b5ba22b4478a6b0202ab827)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications