[all-commits] [llvm/llvm-project] 69878f: [lldb] Refactor JSONTransport own MainLoop read ha...

[John Harrison via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 69878f9fa17ac750e9738b552f8b5a02c0290374
      https://github.com/llvm/llvm-project/commit/69878f9fa17ac750e9738b552f8b5a02c0290374
  Author: John Harrison <harjohn at google.com>
  Date:   2026-02-06 (Fri, 06 Feb 2026)

  Changed paths:
    M lldb/include/lldb/Host/JSONTransport.h
    M lldb/include/lldb/Protocol/MCP/Server.h
    M lldb/include/lldb/Protocol/MCP/Transport.h
    M lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.cpp
    M lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.h
    M lldb/source/Protocol/MCP/Server.cpp
    M lldb/source/Protocol/MCP/Transport.cpp
    M lldb/tools/lldb-dap/DAP.cpp
    M lldb/tools/lldb-dap/Transport.cpp
    M lldb/tools/lldb-dap/Transport.h
    M lldb/tools/lldb-dap/tool/lldb-dap.cpp
    M lldb/unittests/DAP/TestBase.cpp
    M lldb/unittests/DAP/TestBase.h
    M lldb/unittests/Host/JSONTransportTest.cpp
    M lldb/unittests/Protocol/ProtocolMCPServerTest.cpp
    M lldb/unittests/TestingSupport/Host/JSONTransportTestUtilities.h

  Log Message:
  -----------
  [lldb] Refactor JSONTransport own MainLoop read handle. (#179564)

When working with a MainLoop, if the file reaches the EOF it will
immediately fire the read handle callback. We cannot readily determine
if the file is at EOF or if the file is pointing to a socket/pipe that
has consumed all the current data in the buffer but the remote end has
not yet hung up. This is causing JSONTransport to continuously fire the
OnRead callback trigging repeated calls to the
`MessageHandler::OnClose`.

Since MainLoop does not perform the actual read, we need to adjust the
behavior of JSONTransport to fully own the read handle.

This change moves the ownership of the `MainLoop::ReadHandleUP` and
additionally own a reference to the `MainLoop` itself to ensure the loop
outlives the JSONTransport object.

This allows us to remove the handle immediately when we detect an EOF /
hang up has occurred.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications