[all-commits] [llvm/llvm-project] 955fd5: [HLSL] Stop redeclaration of resources types in HL...

[joaosaffran via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 955fd59c92ccb8ffb2aeec966ed4ca29eadf0288
      https://github.com/llvm/llvm-project/commit/955fd59c92ccb8ffb2aeec966ed4ca29eadf0288
  Author: joaosaffran <joaosaffranllvm at gmail.com>
  Date:   2026-02-02 (Mon, 02 Feb 2026)

  Changed paths:
    M clang/lib/Sema/HLSLExternalSemaSource.cpp
    A clang/test/CodeGenHLSL/resources-declared-only-once.hlsl

  Log Message:
  -----------
  [HLSL] Stop redeclaration of resources types in HLSLExternalSemaSource (#178808)

During the declaration of HLSL resource types, we add a delay to the
completion of such declarations to happen during
`HLSLExternalSemaSource::CompleteType`. Such might cause the parser to
declare the resources twice, like here
https://hlsl.godbolt.org/z/aT4b1Goeb, triggering an assert.

This patch fixes this issue by removing the resources out of the
completions declaration list once they are declared.

Fix: #153619



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications